Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce and Implement OverlayedChanges #4462

Open
timwu20 opened this issue Jan 14, 2025 · 0 comments
Open

Introduce and Implement OverlayedChanges #4462

timwu20 opened this issue Jan 14, 2025 · 0 comments

Comments

@timwu20
Copy link
Contributor

timwu20 commented Jan 14, 2025 •
edited
Loading

Issue Summary

Taken from design doc:

Given that storing a block and it's associated storage changes are handled in one BlockImportOperation, we should remove the StoreTrie method entirely from StorageState. Rather BlockState.AddBlock should accept an introduced OverlayedChanges type analogous to the substrate primitive.

OverlayedChanges will be used in future integration work regarding #4458, #4465, #4466. This is used to store any changes is essentially drained and committed to the underlying state storage as part of BlockImportOperation.

Acceptance Criteria

  • Introduce OverlayedChanges type
  • Type specific tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timwu20