Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate iwant list #273

Open
twoeths opened this issue Jun 10, 2022 · 1 comment
Open

Deduplicate iwant list #273

twoeths opened this issue Jun 10, 2022 · 1 comment

Comments

@twoeths
Copy link
Contributor

twoeths commented Jun 10, 2022

Motivation
Right now if n peers sending the same message that we don't have, we'll ask for the same message to these n peers

  • If we receive N IHAVE for a msgId, we will send N IWANT for that msgId
  • We want to deduplicate this
  • This should also help us get more messages that we don't have

Description
Track pendingIWant and clear per heartbeat as referenced in https://github.com/libp2p/rust-libp2p/blob/802d00e645894d8895f2f9f665b921452d992b86/protocols/gossipsub/src/behaviour.rs#L1223

@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants