Boost 1.87.0 breaks the build

[brian6932]

Checklist

• I'm reporting a problem with Chatterino
• I've verified that I'm running the most recent nightly build or stable release
• I've looked for my problem on the wiki
• I've searched the issues and pull requests for similar looking reports

Describe your issue

1.86.0 and below have no such issues.

websocketpp

src/providers/twitch/PubSubManager.hpp(8): fatal error C1083: Cannot open include file: 'boost/asio/io_service.hpp': No such file or directory
lib/websocketpp/websocketpp/transport/asio/connection.hpp(89): error C2039: 'io_service': is not a member of 'websocketpp::lib::asio'
lib/websocketpp/websocketpp/common/asio.hpp(94): note: see declaration of 'websocketpp::lib::asio'
lib/websocketpp/websocketpp/transport/asio/endpoint.hpp(1109): error C2039: 'expires_from_now': is not a member of 'boost::asio::basic_waitable_timer<std::chrono::steady_clock,boost::asio::wait_traits<Clock>,boost::asio::any_io_executor>'
boost/1.87.0/boost/asio/basic_waitable_timer.hpp(140): note: see declaration of 'boost::asio::basic_waitable_timer<std::chrono::steady_clock,boost::asio::wait_traits<Clock>,boost::asio::any_io_executor>'
lib/websocketpp/websocketpp/transport/asio/endpoint.hpp(89): error C2039: 'work': is not a member of 'boost::asio::io_context'
lib/websocketpp/websocketpp/transport/asio/endpoint.hpp(998): error C2039: 'iterator': is not a member of 'boost::asio::ip::basic_resolver<boost::asio::ip::tcp,boost::asio::any_io_executor>'

miniaudio

src/controllers/sound/MiniaudioBackend.cpp(276): error C2039: 'expires_from_now': is not a member of 'boost::asio::basic_waitable_timer<std::chrono::steady_clock,boost::asio::wait_traits<Clock>,boost::asio::any_io_executor>'
boost/1.87.0/boost/asio/basic_waitable_timer.hpp(140): note: see declaration of 'boost::asio::basic_waitable_timer<std::chrono::steady_clock,boost::asio::wait_traits<Clock>,boost::asio::any_io_executor>'

https://www.boost.org/doc/libs/1_86_0/boost/asio/io_service.hpp -> https://www.boost.org/doc/libs/1_87_0/boost/asio/io_service.hpp

https://live.boost.org/doc/libs/1_86_0/doc/html/boost_asio/reference/io_context__work.html -> https://live.boost.org/doc/libs/1_87_0/doc/html/boost_asio/reference/executor_work_guard.html

https://www.boost.org/doc/libs/1_86_0/doc/html/boost_asio/reference/ip__basic_resolver/iterator.html

https://www.boost.org/doc/libs/1_86_0/doc/html/boost_asio/reference/ip__basic_resolver/query.html

https://www.boost.org/doc/libs/1_86_0/doc/html/boost_asio/reference/basic_waitable_timer/expires_from_now.html -> https://www.boost.org/doc/libs/1_87_0/doc/html/boost_asio/reference/basic_waitable_timer/expires_after.html & https://www.boost.org/doc/libs/1_87_0/doc/html/boost_asio/reference/basic_waitable_timer/expiry.html

I have attempted to fix some of these issues on https://github.com/brian6932/chatterino2/tree/fix/boost-1.87.0 & https://github.com/brian6932/websocketpp/tree/fix/boost-1.87.0, but the deprecation of boost::ip::basic_resolver::iterator seems like a bit more than I can handle, so if anyone wants write access to either of the repos, or wants ownership of the latter one transferred to them, let me know.

Screenshots

No response

OS and Chatterino Version

Not relevant

[Nerixyz]

I don't think it's likely that websocketpp will be updated in the near future (maybe a breaking boost version gets them to do so). We should probably move to Boost.Beast.

[Nerixyz]

I made it compile and it passes our tests:

• chatterino: https://github.com/Nerixyz/chatterino2/tree/fix/new-asio
• websocketpp: https://github.com/Nerixyz/websocketpp/tree/fix/new-asio - note that this is only intended at making chatterino compile. I didn't rename mentions of io_service to io_context, since it was a typedef before (also makes the diff more readable).

[Mm2PL]

Ideally I would love for us to stop depending on a library that just breaks our dependencies. There is QWebSocket we could use instead of this mess.

[Nerixyz]

Ideally I would love for us to stop depending on a library that just breaks our dependencies. There is QWebSocket we could use instead of this mess.

I think the general plan is to move to Boost.Beast. The EventSub implementation uses that already. To avoid code duplication, I'd love to have some higher-level wrapper around Boost.Beast. A kind-of websocket pool, since that's what we want in most cases (ideally, plugins could use that as well).

Qt Websockets have one, in my opinion major, drawback: they force you to use UTF16 for text. But we never actually want UTF16, because we're always sending JSON in UTF8. So by using Qt's websockets, we'd have to transcode UTF8 -> UTF16 -> UTF8 both for sending and receiving messages. Especially with EventSub this is suboptimal. A nice feature of them is that we get HTTP and SOCKS proxying for "free".

[brian6932]

If dependence on Boost is unwanted, and UTF8 writing is, there's also https://github.com/machinezone/IXWebSocket.

[Nerixyz]

If dependence on Boost is unwanted, and UTF8 writing is, there's also machinezone/IXWebSocket.

We don't want to drop Boost, and IXWebSocket does not have proxy support at all (https://redirect.github.com/machinezone/IXWebSocket/issues/253).