Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message logger did not start #5771

Open
4 tasks done
ScrubN opened this issue Dec 17, 2024 · 2 comments
Open
4 tasks done

Message logger did not start #5771

ScrubN opened this issue Dec 17, 2024 · 2 comments
Labels
issue-report An issue reported by a user.

Comments

@ScrubN
Copy link
Contributor

ScrubN commented Dec 17, 2024

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

After my Chatterino crashed (#5770), I opened a new instance of Chatterino, which for whatever reason did not ever begin logging. After closing that instance and opening another Chatterino instance, logging resumed again.

Possibly related, but I opened the first new instance before closing the crash handler.

I wish I could be of more help, but I'm not entirely sure how this issue is even possible since there are asserts ensuring that the file is both open and writable.

void appendLine(QFile &fileHandle, const QString &line)
{
assert(fileHandle.isOpen());
assert(fileHandle.isWritable());

Screenshots

No response

OS and Chatterino Version

Chatterino 2.5.2-beta.1 (commit 13d871f) built with Qt 6.7.1, MSVC 194234435, Crashpad Running on Windows 10 Version 22H2, kernel: 10.0.19045

@ScrubN ScrubN added the issue-report An issue reported by a user. label Dec 17, 2024
@Nerixyz
Copy link
Contributor

Nerixyz commented Dec 17, 2024

but I'm not entirely sure how this issue is even possible since there are asserts ensuring that the file is both open and writable.

These asserts are only active in debug mode. In release mode, they're no-ops.

@ScrubN
Copy link
Contributor Author

ScrubN commented Jan 7, 2025

After experiencing 2 more crashes, it seems that the logger does not start when Chatterino is restarted automatically after a crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue-report An issue reported by a user.
Projects
None yet
Development

No branches or pull requests

2 participants