Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use the console in downloadModel.ts #157

Open
binarykitchen opened this issue Jan 10, 2025 · 0 comments
Open

Do not use the console in downloadModel.ts #157

binarykitchen opened this issue Jan 10, 2025 · 0 comments

Comments

@binarykitchen
Copy link
Contributor

Please do not use console but logger in this file
https://github.com/ChetanXpro/nodejs-whisper/blob/main/src/downloadModel.ts#L63

I've noticed it gets logged the wrong way when you download and compile a model.

Also, in some places I still see console.error(...) ... please change to logger.error(...) thanks :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@binarykitchen