Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units system #111

Open
ChunHuangPhy opened this issue Nov 7, 2024 · 0 comments
Open

Units system #111

ChunHuangPhy opened this issue Nov 7, 2024 · 0 comments

Comments

@ChunHuangPhy
Copy link
Owner

Density function in most of the inference notebook are not in a consistent unit, we need to change

density = np.logspace(14.3,15.6, 50)

to density = np.logspace(14.3,15.6, 50)*g_cm_3

but that require change in likelihood and TOV solver

also need to change the definition of likelihood

for example, the MRgaussian, need to define the mass and radius to be something times their own unit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant