Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Issues from first run through #5

Open
textbook opened this issue Jun 9, 2019 · 0 comments
Open

WIP - Issues from first run through #5

textbook opened this issue Jun 9, 2019 · 0 comments

Comments

@textbook
Copy link
Member

textbook commented Jun 9, 2019

  • Prettier collapses <element></element> to <element/>, e.g. for main and header. Some students were confused by this and not sure how to get back to being able to put children in those elements. Maybe put some content in each one so the page isn't initially blank, too?
  • Prettier also adds lots of changes (quotes, line breaks) which makes the commit bigger than it needs to be. We should start from a consistent format (tracking: https://trello.com/c/QP4ZZsgt, and you can configure VSCode to make Prettier use ESLint).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant