Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Transposing tabs with string adjustments. #1587

Open
1 task done
DevJett opened this issue Jul 17, 2024 · 1 comment
Open
1 task done

Improvement: Transposing tabs with string adjustments. #1587

DevJett opened this issue Jul 17, 2024 · 1 comment
Assignees
Labels
area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on. type-improvement 🚀

Comments

@DevJett
Copy link

DevJett commented Jul 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I'm experiencing issues with the transposition feature not working as expected. When I set transpositionPitches: [-4], the notes incorrectly go below 0. Instead, they should move up a string rather than displaying a -1.

Steps to Reproduce:

  1. Open the attached guitar tab file with no transposition applied (see Screenshot 1).
  2. Set transpositionPitches to [-4].
  3. Observe the transposed guitar tab (see Screenshot 2).

Expected Behavior:
The notes should transpose correctly by moving up a string instead of displaying a negative value, as demonstrated in the expected output from Songsterr (see Screenshot 3).

Screenshots:

  1. No transposition applied:
    Screenshot 2024-07-17 at 14 26 35

  2. After Setting transpositionPitches to [-4]:
    Screenshot 2024-07-17 at 14 28 52

  3. Expected Transposition Output - Screenshot from Songsterr for the same tab:

Screenshot 2024-07-18 at 01 15 47

Expected Behavior

The notes should transpose correctly by moving up a string instead of displaying a negative value, as demonstrated in the expected output from Songsterr (see Screenshot 3 above).

Steps To Reproduce

  1. Download the GP File:

  2. Set the Transposition:

    • Open the downloaded file and set transpositionPitches to [-4].
  3. Observe the Issue:

    • You will notice that the notes incorrectly move below 0, displaying negative values.
  4. Compare with Songsterr:

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.4 (alpha)

Platform

Web

Environment

- **OS**:
- **Browser**:
- **.net Version**:

Anything else?

No response

@DevJett DevJett added the state-needs-triage Bug not triaged yet. label Jul 17, 2024
@Danielku15
Copy link
Member

Danielku15 commented Jul 20, 2024

This is currently the expected behavior and not a bug. AlphaTab doesn't have a feature to dynamically transpose tabs (adjusting strings).

In simple scenarios like yours it is maybe not a problem. But consider scenarios where the transpostion and string change leads to overlaps. Also there are scenarios where you notes are lost as they cannot be played anymore on the current tuning.

@Danielku15 Danielku15 added type-improvement 🚀 and removed state-needs-triage Bug not triaged yet. labels Jul 20, 2024
@Danielku15 Danielku15 changed the title Bug Report: Issue with Transposition Feature Improvement: Transposing tabs with string adjustments. Jul 20, 2024
@Danielku15 Danielku15 added area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. platform-all Affects all platforms labels Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on. type-improvement 🚀
Projects
None yet
Development

No branches or pull requests

2 participants