Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]better armor-value lock. #103

Open
wootaboot opened this issue Sep 25, 2019 · 8 comments
Open

[Feature request]better armor-value lock. #103

wootaboot opened this issue Sep 25, 2019 · 8 comments

Comments

@wootaboot
Copy link

the armor-value lock feature does not take into account that different pieces of the same set have different values. i.e diamond armor boots and diamond armor chest would have very different requirements because chest gives more armor. just want to have a feature that takes that into consideration due to the randomness of armor making with TiC armor.

@pupnewfster
Copy link
Contributor

pupnewfster commented Sep 25, 2019

Are you talking about the ability to lock armor or the integration that CompatSkills (while also done by us this is not the correct issue tracker for): https://docs.blamejared.com/1.12/en/#Mods/CompatSkills/Supports/Minecraft/Armor_Point_Locking/

Given the latter does it by the value the armor gives so a chestplate would have a higher requirement if you set a higher value for it.

@wootaboot
Copy link
Author

yes, i set it so that every .8 of armor requires 1 level of defense. however this makes it so the best armor takes different levels to use where as i want it to have level 32 defense. normally i would just give the armor fixed values but with TiC armor add-on, the armor isnt fixed so there is no way for me to do it that way.(boots take level 12 but chest takes level 32). i fix would be a compatability patch for the armor add-on that works with defense instead of armor.(Defense is fixed and tells you how much armor you will have with a full set and each piece gives a percentage of the defense in armor.
2019-09-25_18 52 06
2019-09-25_18 51 55

@pupnewfster pupnewfster transferred this issue from Coders-After-Dark/Reskillable Sep 25, 2019
@pupnewfster
Copy link
Contributor

(Transfered this to CompatSkills issue tracker)

I will leave this open as a feature request for a way to lock by defense level. But the armor value locking works as intended, in fact I made the armor lock value with the exact purpose of using it with constructs armory, so as to dynamically lock things based on their combined armor values.

@pupnewfster
Copy link
Contributor

I don't know if it is stored in NBT as back when I used constructs armory I don't believe it had a "defense" level, but if it is stored somewhere in the NBT of the item, you can use a partial NBT lock to match specific "defense" levels.

@wootaboot
Copy link
Author

defense is stored in NBT so ill try to get that to work, thanks.

@wootaboot
Copy link
Author

seems it works but it has to be very specific. Any way to make it so that its greater then or equal to number for NBT tags?

@pupnewfster
Copy link
Contributor

Nope, best you could do is if they are all whole numbers just loop over a bunch of values adding them for each.

@wootaboot
Copy link
Author

well dont know if they are always integers but i think that there is a finite number of possibilities so ill probably just make a function to hit them all. Thanks for all the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants