Bug(?): TiC Compat (Modifier Locking), MC1.12.2

[RowanMaBoot]

Forge version:

• 14.23.5.2847

Mods in use:

• MTLib-3.0.6.jar
• CraftTweaker2-1.12-4.1.19.jar
• modtweaker-4.0.17.jar
• Reskillable-1.12.2-1.13.0.jar
• CompatSkills-1.12.2-1.17.0.jar
• Mantle-1.12-1.3.3.55.jar
• TConstruct-1.12.2-2.13.0.171.jar

Issue breakdown:

1. Launch Minecraft (in this case, using an MultiMC instance) with the above mods & forge version.
2. Create a new world (leave default, but set up as creative).
3. Whilst in creative, add (Tinkers Construct) Wooden Pickaxe, Stone Pickaxe, Tinkers Tool Station, Diamond, Emerald, Stack of Redstone and Stack of Quartz to inventory.
4. Switch to survival via command, place down table.
5. MaterialLock in this case is functional, and is accurately reflected for the Wooden Pickaxe - which cannot be used.
6. Now try to add the Diamond, Emerald, Quartz or Redstone to the Stone Pickaxe via the Tool Station - you are not only able to add these parts/modifiers without issue, but no restrictions are placed. As such there appears to be an issue with the ModifierLock function

Example script for possible replication:

// TINKERS CONSTRUCT MODIFIERS

print("Initialising test_compatskills.zs..");

mods.compatskills.MaterialLock.addMaterialLock("wood", "reskillable:mining|2", "reskillable:magic|2");

mods.compatskills.ModifierLock.addModifierLock("haste", "reskillable:agility|12", "reskillable:defense|7");
mods.compatskills.ModifierLock.addModifierLock("sharpness", "reskillable:agility|12", "reskillable:defense|7");
mods.compatskills.ModifierLock.addModifierLock("emerald", "reskillable:agility|12", "reskillable:defense|7");
mods.compatskills.ModifierLock.addModifierLock("diamond", "reskillable:agility|12", "reskillable:defense|7");

print("Initialised test_compatskills.zs");

Confirming that right name is being referenced (per CT log output after using /ct tinkersmodifiers (which I will note is typo'd within CT documentation, but I digress):

## Haste
#  Identifier: haste
#  Localized:  Haste
#  Description:Weeeeeee!\nThe redstone impulse when using your tool motivates your tool to move even faster.

As referenced in CT logs:

[POSTINITIALIZATION][CLIENT][INFO] Added Material Lock for Material: wood With Requirements: reskillable:mining|2, reskillable:magic|2
[POSTINITIALIZATION][CLIENT][INFO] Added Modifier Lock for Modifier: haste With Requirements: reskillable:agility|12, reskillable:defense|7
[POSTINITIALIZATION][CLIENT][INFO] Added Modifier Lock for Modifier: sharpness With Requirements: reskillable:agility|12, reskillable:defense|7
[POSTINITIALIZATION][CLIENT][INFO] Added Modifier Lock for Modifier: emerald With Requirements: reskillable:agility|12, reskillable:defense|7
[POSTINITIALIZATION][CLIENT][INFO] Added Modifier Lock for Modifier: diamond With Requirements: reskillable:agility|12, reskillable:defense|7

Note that the above syntax used as part of the ZenScript etc. is per documentation via https://docs.blamejared.com/1.12/en/#Mods/CompatSkills/Supports/TConstruct/ModifierLocks/ModifierLock/

Additionally I am also seeing strange (where it is similarly not working, except in a case example where the ModifierLock is successful and is having the desired affected) behaviour with Construct's Armoury:

conarm-1.12.2-1.2.5.3.jar

mods.compatskills.ModifierLock.addModifierLock("speedy_armor", "reskillable:agility|12", "reskillable:defense|7");

Results in a successful block for Redstone against armour, so it cannot be added as a modifier say to an Iron Chestplate - or if you add via creative, the armour piece cannot be worn. This is expected behaviour.

But the following successfully register per logs, but do not add restrictions.

mods.compatskills.ModifierLock.addModifierLock("emerald_armor", "reskillable:agility|12", "reskillable:defense|7");
mods.compatskills.ModifierLock.addModifierLock("diamond_armor", "reskillable:agility|12", "reskillable:defense|7");

Alternatively there is a misunderstanding from my end as to the intention of the ModifierLock. Regardless, hope this report is of some use - I did a cursory check and didn't see anything of this nature reported by any other users.

[royalcw]

I am also experiencing an issue with TiC modifiers not adding requirements once they put on tools. All mods are updated and function for 1.12 as of 28 Dec 19. Reskillable version is 1.13.

[ghost]

I am having the same issue where all of my tinker's construct tools are usable no matter the mining ability (obsidian in this case).