Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additive nbt skill reqs to primary reqs #53

Open
royalcw opened this issue May 20, 2018 · 1 comment
Open

Additive nbt skill reqs to primary reqs #53

royalcw opened this issue May 20, 2018 · 1 comment
Labels
enhancement New feature or request Low Priority Reskillable Change probably required in Reskillable to be able to support of fix

Comments

@royalcw
Copy link

royalcw commented May 20, 2018

Looking to have a config/toggle that allows enchants and other nbt tags (i.e. EnderIO Dark Armor) to be additive. Example: Thaumcraft robe might require reskillable:magic|15 and reskillable:defense|5. If I enchant with with protection IV with a reskillable:magic|4 requirement then the new enchanted robe would now be magic|19 and defense|5. This could also help with Tinker's Tools by making specific upgrades cost a static amount that is added to the base tool to use.

The current system only takes the highest of the two so the enchanted requirement is the same as the unenchanted requirement. There could be a skill max check to cap the total requirement at the max skill but this will make having 3 enchants more difficult to equip than 1 enchant...which makes sense to me.

@royalcw
Copy link
Author

royalcw commented May 20, 2018

this request goes nicely with the oreDict ticket....hence all "ore:pickaxe" items with an enchant tag would require compatskill:xxxxxxx|4 (or reskillable:magic|4) additional requirement if you put the fortune IV enchant (nbt tag) on a pickaxe that is added to a oreDict. This systems allows dynamic skill requirements per tool/weapon/armor.

@pupnewfster pupnewfster added enhancement New feature or request Low Priority Reskillable Change probably required in Reskillable to be able to support of fix labels Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Low Priority Reskillable Change probably required in Reskillable to be able to support of fix
Projects
None yet
Development

No branches or pull requests

2 participants