Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Manage node templates in workflow sidebar tab #1801

Open
1 task done
huchenlei opened this issue Dec 4, 2024 · 4 comments
Open
1 task done

[Feature Request]: Manage node templates in workflow sidebar tab #1801

huchenlei opened this issue Dec 4, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@huchenlei
Copy link
Member

huchenlei commented Dec 4, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Replace the current node template management system with an extra folder in workflow sidebar tab.

Proposed workflow

  • Open workflow sidebar tab
  • See a folder with a different icon and name Templates for current node templates

Additional information

  • Exsiting node template management should be removed.
  • User should still be able to add template via the context menu.
  • Storage of templates are converted to normal workflow format and save in workflows/Templates/ directory

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei added the enhancement New feature or request label Dec 4, 2024
@Steudio
Copy link

Steudio commented Jan 13, 2025

Any updates regarding this? Is there anything we can do to help ?

@christian-byrne
Copy link
Collaborator

christian-byrne commented Jan 14, 2025

If you are thinking about making a PR, you could try moving or copying all workflows inside ComfyUI/user/(username)/comfy.templates.json into their own files in ComfyUI/user/(username)/workflows/templates, then change the 'Save Selected as Template' context menu command so it just saves a workflow normally in that same place.

The node template feature can be emulated right now using workflow-insert feature.

@Steudio
Copy link

Steudio commented Jan 15, 2025

Thanks a lot for bringing the workflow-insert feature to my attention.
In theory, this should have worked, but in reality, it doesn't. There is something broken with the workflow-insert feature, but I don't know what it is yet.

From what I have noticed so far, some workflows can be inserted, while others cannot. It seems to depend on which nodes are inside the workflow to be inserted or the current workflow it is being inserted into.

I'll investigate more, but it may be linked to the reroute nodes from RGThree.

@christian-byrne
Copy link
Collaborator

Thanks a lot for bringing the workflow-insert feature to my attention. In theory, this should have worked, but in reality, it doesn't. There is something broken with the workflow-insert feature, but I don't know what it is yet.

From what I have noticed so far, some workflows can be inserted, while others cannot. It seems to depend on which nodes are inside the workflow to be inserted or the current workflow it is being inserted into.

I'll investigate more, but it may be linked to the reroute nodes from RGThree.

No problem. I submitted fix for RGThree reroute:

Temporary fix is to either use new beta reroute which I recommend or making sure to put a RGThree reroute onto the graph manually before inserting a workflow that contains one, as it seems to prevent issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants