Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Expr instead of QuoteNode #36

Closed
AntonReinhard opened this issue Oct 3, 2024 · 1 comment
Closed

Use Expr instead of QuoteNode #36

AntonReinhard opened this issue Oct 3, 2024 · 1 comment

Comments

@AntonReinhard
Copy link
Member

In some functions, e.g. gen_access_expr, strings are still parsed into QuoteNodes. Ideally, this should be done directly through the Expr() syntax instead.
@AntonReinhard
Copy link
Member Author

These instances are now gone with #40. The only remaining Meta.parse calls are now in the GPU kernel functions which would be cumbersome to type as expressions, and in the test model, where it should be allowed anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AntonReinhard