Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom note base URL, used only when displaying the share link of the note #387

Open
3 tasks done
panjd123 opened this issue Jan 9, 2025 · 0 comments
Open
3 tasks done
Labels
enhancement New feature or request

Comments

@panjd123
Copy link

panjd123 commented Jan 9, 2025

What type of request is this?

New feature idea

Clear and concise description of the feature you are proposing

I really hope to have a configuration parameter that allows the webpage to use a custom base URL when displaying the share link of the note, instead of the current host of the client.
I am not referring to the API's base URL, but just a display difference.

e.g. http://127.0.0.1:8787/xxxxxxx to https://www.example.com/xxxxxxx

Here is the use case: the domain name used when creating this note might be different from the domain name I want to share with others. For example, I access this service using an intranet, but I want to use a public FRP service domain name by default to share.

I think this is a very simple feature, and I am happy to add it to the code myself. I wrote a very simple piece of code, but I don't know why it didn't work as I expected. Specifically, how should I pass this parameter in like other environment variables?

#386

Additional context

No response

Validations

  • Check the feature is not already implemented in the project.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Check that the feature is technically feasible and aligns with the project's goals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant