Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units in tests #2

Open
edwardsmith999 opened this issue Jun 15, 2020 · 0 comments
Open

Units in tests #2

edwardsmith999 opened this issue Jun 15, 2020 · 0 comments
Assignees

Comments

@edwardsmith999
Copy link
Member

The unit test in CPLSediFOAM tests are disabled and the units used are very clearly not correct (e.g U has units of M/T^2). This was due to an problem getting the code to run with various conventions and input formats but causes confusion over the correct form of the input.

We need to

Fit all units to the correct form in the test inputs and enable unit testing
Make any needed changes to ensure all test pass as before

@edwardsmith999 edwardsmith999 self-assigned this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant