Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isSource comparison provides incorrect result in some use cases #10

Open
MarcusBarnes opened this issue Sep 7, 2017 · 0 comments
Open

isSource comparison provides incorrect result in some use cases #10

MarcusBarnes opened this issue Sep 7, 2017 · 0 comments

Comments

@MarcusBarnes
Copy link

This issue is regarding this block of code:
https://github.com/CtrHellenicStudies/OpenVideoAnnotation/blob/master/src/ova.js#L739-L756
My team had a use case where the results of targetSrc and playerSrc were different because playerSrc was a relative link and the values are set based on using lastIndexOf(".").

We have a modification that addresses the issue. I will create a pull-request for review. Thank you in advance.
MarcusBarnes added a commit to digitalutsc/OpenVideoAnnotation that referenced this issue Sep 7, 2017
@MarcusBarnes
Addresses issue CtrHellenicStudies#10.
4bd8c58
@MarcusBarnes MarcusBarnes mentioned this issue Sep 7, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarcusBarnes