Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HLE symbol detection #41

Open
RadWolfie opened this issue Aug 24, 2018 · 0 comments
Open

Refactor HLE symbol detection #41

RadWolfie opened this issue Aug 24, 2018 · 0 comments
Labels
OOVPA Any OOVPA change relative task

Comments

@RadWolfie
Copy link
Member

Moved from Cxbx-Reloaded/Cxbx-Reloaded#1119

Original post by @PatrickvL:

Currently, there's lots of code in HLE intercept that resolves a number of symbols. This code has grown out of proportion and is difficult to maintain.

For this issue, de-duplicate similarly looking code by moving it towards functions that can handle all current situations.

This issue would become less cumbersome if OOVPA-based XREF lookup is done first - see #39

Since op post is not very descriptive of where the code is at. See original issue for detail comments linked at top of the post.

@RadWolfie RadWolfie added OOVPA Any OOVPA change relative task labels Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OOVPA Any OOVPA change relative task
Projects
None yet
Development

No branches or pull requests

1 participant