You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Users cannot use roughness map if the file name starts with a digit
Why
Roughness map can be used using the same keyword as constant values. This is helpful in many situation where one doesn't have to remember a different keywords for maps or cst values.
However BG_Flood has to determine whether the user input is a file or a number. At the moment the code checks whether the first character is a number. If not it must be a file!
if (!parametervalue.empty())
{
if (std::isdigit(parametervalue[0]) == false)
{
forcing.cf = readfileinfo(parametervalue, forcing.cf);
}
}
It is a problem
When the user forgets about the quirk above and use a digit in the first character of the file this becomes a silent issue where a value not intended is used for roughness.
Solution?
change the std::isdigit(parametervalue[0]) == false to:
NOT (all characters are digits (or "."))
any character that is not "." is non-digit
more than one non-digit character
The text was updated successfully, but these errors were encountered:
The issue
Users cannot use roughness map if the file name starts with a digit
Why
Roughness map can be used using the same keyword as constant values. This is helpful in many situation where one doesn't have to remember a different keywords for maps or cst values.
However BG_Flood has to determine whether the user input is a file or a number. At the moment the code checks whether the first character is a number. If not it must be a file!
It is a problem
When the user forgets about the quirk above and use a digit in the first character of the file this becomes a silent issue where a value not intended is used for roughness.
Solution?
change the
std::isdigit(parametervalue[0]) == false
to:The text was updated successfully, but these errors were encountered: