SerializedReactiveProperties Odin Inspector support

[devcube9]

Thank you for developing this amazing framework.

Currently, when using SerializedReactiveProperties with Odin inspector, there is an error when changing their values in the inspector.

R3/src/R3.Unity/Assets/R3.Unity/Runtime/SerializableReactiveProperty.cs

Line 70 in 2eaf201

? fieldInfo.GetValue(attachedComponent)

Similar issues was found in UniRx here:

neuecc/UniRx#531
neuecc/UniRx#452

Unlike the issues in UniRx, fieldInfo is null in R3

[neuecc]

thanks, I'll check it.

[neuecc]

I've tested at Unity 6000.0.20f1 and Odin 3.3.1.8, maybe it works.
Can you check it for me?
Also, I would be grateful if you could provide the MonoBehaviour code for the case where it doesn't work.

[devcube9]

using R3;
using Sirenix.OdinInspector;
using UnityEngine;

class Test {
    [SerializeField] private SerializableReactiveProperty<int> reactiveProperty;
}

public class SerializableReactivePropertyOdinError : SerializedMonoBehaviour {

    [SerializeField] private Test test;

}

I tested again and found that it only throws an error when a SerializableReactiveProperty is nested inside a class

[neuecc]

thanks, I'll check it again.

[alijaya]

any update on this? It's happen when ReactiveProperty is serialized by Odin Serialization. So it will happen too when SerializableReactiveProperty<int> inside the MonoBehaviour and marked with [OdinSerialize, NonSerialized]

[alijaya]

Hi, I've tested this, and somehow fieldInfo is not always non-null, so there's a case where it's null, not sure what.
I've solved this by changing this lines

var targetProp = (paths.Length == 1)
                    ? fieldInfo.GetValue(attachedComponent)
                    : GetValueRecursive(attachedComponent, 0, paths);

into

var targetProp = GetValueRecursive(attachedComponent, 0, paths);

So don't need to check if paths.Length is 1, and just skip the fieldInfo altogether and use GetValueRecursive

And it's working now.

[neuecc]

I see, retrieving fresh FieldInfo from Type.
Since my Odin trial has expired, I can't test it, but that approach seems viable.