From c3ad1aeed6be9fb9a2faa15837164bde98b43bcc Mon Sep 17 00:00:00 2001 From: joegibb Date: Mon, 16 Dec 2024 16:46:34 +0000 Subject: [PATCH 1/3] change wording on benefits partial --- app/views/content/shared/teaching/_benefits_generic.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/content/shared/teaching/_benefits_generic.html.erb b/app/views/content/shared/teaching/_benefits_generic.html.erb index 2772b651b5..c81234b03d 100644 --- a/app/views/content/shared/teaching/_benefits_generic.html.erb +++ b/app/views/content/shared/teaching/_benefits_generic.html.erb @@ -2,7 +2,7 @@

In addition to the personal rewards of teaching, there are practical benefits too, including:

From 59399594b2c246b702726daf63a5b875d1645474 Mon Sep 17 00:00:00 2001 From: joegibb Date: Tue, 17 Dec 2024 08:28:14 +0000 Subject: [PATCH 2/3] change genrous to secure on pension pages --- .../landing/how-much-do-teachers-get-paid/_collage.html.erb | 2 +- .../life-as-a-teacher/pay-and-benefits/_categories.html.erb | 2 +- .../content/life-as-a-teacher/pay-and-benefits/teacher-pay.md | 2 +- app/views/content/shared/teaching/_benefits.html.erb | 2 +- app/views/content/shared/teaching/_benefits_generic.html.erb | 2 +- spec/views/content/shared/benefits.html.erb_spec.rb | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/views/content/landing/how-much-do-teachers-get-paid/_collage.html.erb b/app/views/content/landing/how-much-do-teachers-get-paid/_collage.html.erb index 717ffa301d..adb967105d 100644 --- a/app/views/content/landing/how-much-do-teachers-get-paid/_collage.html.erb +++ b/app/views/content/landing/how-much-do-teachers-get-paid/_collage.html.erb @@ -3,7 +3,7 @@

- A rewarding salary, substantial pension, and generous + A rewarding salary, secure pension, and generous holidays are just some of the great benefits of a career in teaching.

diff --git a/app/views/content/life-as-a-teacher/pay-and-benefits/_categories.html.erb b/app/views/content/life-as-a-teacher/pay-and-benefits/_categories.html.erb index 55ea85d1bc..21144c2e3c 100644 --- a/app/views/content/life-as-a-teacher/pay-and-benefits/_categories.html.erb +++ b/app/views/content/life-as-a-teacher/pay-and-benefits/_categories.html.erb @@ -12,7 +12,7 @@ <%= render Categories::CardComponent.new(heading_tag: "h2", card: OpenStruct.new( title: "Teacher pensions", - description: "Learn more about the teachers' pension scheme which is one of the most generous in the country.", + description: "Learn more about the teachers' pension scheme which will help you save for your future.", path: "/life-as-a-teacher/pay-and-benefits/teachers-pension-scheme" )) %> diff --git a/app/views/content/life-as-a-teacher/pay-and-benefits/teacher-pay.md b/app/views/content/life-as-a-teacher/pay-and-benefits/teacher-pay.md index 18d7b8f5b6..91247cceee 100644 --- a/app/views/content/life-as-a-teacher/pay-and-benefits/teacher-pay.md +++ b/app/views/content/life-as-a-teacher/pay-and-benefits/teacher-pay.md @@ -147,7 +147,7 @@ For comparison, you'd work 227 days per year (on average) if you worked full tim ## Teachers' pension scheme -The teachers’ pension scheme is one of the most generous in the country and includes an employer contribution of 28.6%. + One of the great benefits of a teaching career is a secure pension with employer contributions of 28.6%. It is a 'defined benefit' pension and is: diff --git a/app/views/content/shared/teaching/_benefits.html.erb b/app/views/content/shared/teaching/_benefits.html.erb index 9aa3138c60..4153816745 100644 --- a/app/views/content/shared/teaching/_benefits.html.erb +++ b/app/views/content/shared/teaching/_benefits.html.erb @@ -2,7 +2,7 @@

In addition to the personal rewards of teaching <%= @front_matter["subject"] %>, there are practical benefits too, including:

diff --git a/app/views/content/shared/teaching/_benefits_generic.html.erb b/app/views/content/shared/teaching/_benefits_generic.html.erb index c81234b03d..f08ea31979 100644 --- a/app/views/content/shared/teaching/_benefits_generic.html.erb +++ b/app/views/content/shared/teaching/_benefits_generic.html.erb @@ -2,7 +2,7 @@

In addition to the personal rewards of teaching, there are practical benefits too, including:

diff --git a/spec/views/content/shared/benefits.html.erb_spec.rb b/spec/views/content/shared/benefits.html.erb_spec.rb index 4effc02723..0bfd7fea49 100644 --- a/spec/views/content/shared/benefits.html.erb_spec.rb +++ b/spec/views/content/shared/benefits.html.erb_spec.rb @@ -13,7 +13,7 @@ it { is_expected.to have_css("ul li") } it { is_expected.to have_link("competitive salary starting at", href: "/life-as-a-teacher/pay-and-benefits/teacher-pay") } - it { is_expected.to have_link("generous and secure pension", href: "/life-as-a-teacher/pay-and-benefits/teachers-pension-scheme") } + it { is_expected.to have_link("a secure pension", href: "/life-as-a-teacher/pay-and-benefits/teachers-pension-scheme") } it { is_expected.to have_text(subject_name) } it { is_expected.to have_text(salary_value) } end From 13b23a6f128eaa9237d391153ae333405c95d930 Mon Sep 17 00:00:00 2001 From: joegibb Date: Tue, 17 Dec 2024 08:41:36 +0000 Subject: [PATCH 3/3] fix issue --- spec/views/content/shared/benefits.html.erb_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/views/content/shared/benefits.html.erb_spec.rb b/spec/views/content/shared/benefits.html.erb_spec.rb index 0bfd7fea49..f217720fc4 100644 --- a/spec/views/content/shared/benefits.html.erb_spec.rb +++ b/spec/views/content/shared/benefits.html.erb_spec.rb @@ -13,7 +13,7 @@ it { is_expected.to have_css("ul li") } it { is_expected.to have_link("competitive salary starting at", href: "/life-as-a-teacher/pay-and-benefits/teacher-pay") } - it { is_expected.to have_link("a secure pension", href: "/life-as-a-teacher/pay-and-benefits/teachers-pension-scheme") } + it { is_expected.to have_link("secure pension", href: "/life-as-a-teacher/pay-and-benefits/teachers-pension-scheme") } it { is_expected.to have_text(subject_name) } it { is_expected.to have_text(salary_value) } end