From 647c7c400565a939d084f5ce1ab2983bdd9e82fd Mon Sep 17 00:00:00 2001
From: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com>
Date: Thu, 12 Dec 2024 11:10:52 +0000
Subject: [PATCH 1/6] Update mailing list postcode step
---
app/views/mailing_list/steps/_postcode.html.erb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/views/mailing_list/steps/_postcode.html.erb b/app/views/mailing_list/steps/_postcode.html.erb
index 86efe9b4b8..7169284054 100644
--- a/app/views/mailing_list/steps/_postcode.html.erb
+++ b/app/views/mailing_list/steps/_postcode.html.erb
@@ -6,7 +6,7 @@
size: "xl",
text: t('helpers.label.mailing_list_steps_postcode.address_postcode', **Value.data),
} do %>
-
If you give us your postcode, we'll let you know about events happening near you.
+ We'll only use this to send you information about events happening near you.
<% end %>
-
We run in-person events in the UK that we can tell you about if you give us your UK postcode.
-
If you do not live in the UK, you do not need to give us your postcode.
-
Instead, you can just select 'Complete sign up' to finish signing up for your event.
+
We run in-person events in the UK. We can tell you about these if you give us your UK postcode.
+
If you do not live in the UK, you do not need to give us your postcode. Instead, you can just select 'Complete sign up' to finish signing up for your event.
diff --git a/app/views/mailing_list/steps/_postcode.html.erb b/app/views/mailing_list/steps/_postcode.html.erb
index 7169284054..30181d3ae4 100644
--- a/app/views/mailing_list/steps/_postcode.html.erb
+++ b/app/views/mailing_list/steps/_postcode.html.erb
@@ -16,8 +16,7 @@
-
We run in-person events in the UK that we can tell you about if you give us your UK postcode.
-
If you do not live in the UK, you do not need to give us your postcode.
-
Instead, you can just select 'Complete sign up' to receive tailored guidance about teacher training.
+
We run in-person events in the UK. We can tell you about these if you give us your UK postcode.
+
If you do not live in the UK, you do not need to give us your postcode. Instead, you can just select 'Complete sign up' to receive tailored guidance about teacher training.
From 164dc5b6165235d000a2acf8fbe8bb1db73be24c Mon Sep 17 00:00:00 2001
From: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com>
Date: Tue, 17 Dec 2024 09:37:17 +0000
Subject: [PATCH 5/6] update question wording
---
config/locales/en.yml | 2 +-
docs/sign-up-journeys.md | 2 +-
spec/features/mailing_list_wizard_spec.rb | 10 +++++-----
spec/integration/mailing_list_spec.rb | 4 ++--
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/config/locales/en.yml b/config/locales/en.yml
index ffc62b2031..eb575c7df4 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -811,7 +811,7 @@ en:
mailing_list_steps_subject:
preferred_teaching_subject_id: Which subject do you want to teach?
mailing_list_steps_postcode:
- address_postcode: Your UK postcode (optional)
+ address_postcode: What's your UK postcode? (optional)
search:
search: Search for ...
diff --git a/docs/sign-up-journeys.md b/docs/sign-up-journeys.md
index 5ac22181e4..d3249ae487 100644
--- a/docs/sign-up-journeys.md
+++ b/docs/sign-up-journeys.md
@@ -18,7 +18,7 @@ graph TD;
teacher_training --> subject[Which subject do you want to teach?]
- subject --> postcode["Your UK postcode (optional)"]
+ subject --> postcode["What's your UK postcode? (optional)"]
postcode --> show_welcome_guide{Show welcome guide?}
diff --git a/spec/features/mailing_list_wizard_spec.rb b/spec/features/mailing_list_wizard_spec.rb
index 688044323c..f787d63631 100644
--- a/spec/features/mailing_list_wizard_spec.rb
+++ b/spec/features/mailing_list_wizard_spec.rb
@@ -37,7 +37,7 @@
click_on "Next step"
expect(page).to have_text "We'll only use this to send you information about events happening near you"
- fill_in "Your UK postcode (optional)", with: "TE57 1NG"
+ fill_in "What's your UK postcode? (optional)", with: "TE57 1NG"
click_on "Complete sign up"
expect(page).to have_title("You've signed up | Get Into Teaching")
@@ -78,7 +78,7 @@
click_on "Next step"
expect(page).to have_text "We'll only use this to send you information about events happening near you"
- fill_in "Your UK postcode (optional)", with: "TE57 1NG"
+ fill_in "What's your UK postcode? (optional)", with: "TE57 1NG"
click_on "Complete sign up"
expect(page).to have_text "Test, you're signed up"
@@ -117,7 +117,7 @@
click_on "Next step"
expect(page).to have_text "We'll only use this to send you information about events happening near you"
- fill_in "Your UK postcode (optional)", with: "TE57 1NG"
+ fill_in "What's your UK postcode? (optional)", with: "TE57 1NG"
click_on "Complete sign up"
expect(page).to have_text "Test, you're signed up"
@@ -156,7 +156,7 @@
click_on "Next step"
expect(page).to have_text "We'll only use this to send you information about events happening near you"
- fill_in "Your UK postcode (optional)", with: "TE57 1NG"
+ fill_in "What's your UK postcode? (optional)", with: "TE57 1NG"
click_on "Complete sign up"
expect(page).to have_text "Test, you're signed up"
@@ -346,7 +346,7 @@
click_on "Next step"
expect(page).to have_text "We'll only use this to send you information about events happening near you"
- fill_in "Your UK postcode (optional)", with: ""
+ fill_in "What's your UK postcode? (optional)", with: ""
click_on "Complete sign up"
expect(page).to have_text "you're signed up"
diff --git a/spec/integration/mailing_list_spec.rb b/spec/integration/mailing_list_spec.rb
index 67879f7b75..df23081a4e 100644
--- a/spec/integration/mailing_list_spec.rb
+++ b/spec/integration/mailing_list_spec.rb
@@ -56,7 +56,7 @@ def sign_up(first_name, last_name, email)
click_on "Next step"
expect(page).to have_text "We'll only use this to send you information about events happening near you"
- fill_in "Your UK postcode (optional)", with: "TE57 1NG"
+ fill_in "What's your UK postcode? (optional)", with: "TE57 1NG"
click_on "Complete sign up"
expect(page).to have_text("you're signed up")
@@ -89,7 +89,7 @@ def sign_up_if_not_qualified(first_name, last_name, email)
click_on "Next step"
expect(page).to have_text "We'll only use this to send you information about events happening near you"
- fill_in "Your UK postcode (optional)", with: "TE57 1NG"
+ fill_in "What's your UK postcode? (optional)", with: "TE57 1NG"
click_on "Complete sign up"
expect(page).to have_text("you're signed up")
From 08e6b4a346b633109a5483cb3b0b09afae711eac Mon Sep 17 00:00:00 2001
From: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com>
Date: Thu, 2 Jan 2025 16:20:33 +0000
Subject: [PATCH 6/6] change 'what is' to 'what's'
---
config/locales/en.yml | 2 +-
spec/features/event_wizard_spec.rb | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/config/locales/en.yml b/config/locales/en.yml
index eb575c7df4..a68f3a8bd8 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -785,7 +785,7 @@ en:
events_steps_contact_details:
address_telephone: What is your telephone number? (optional)
events_steps_personalised_updates:
- address_postcode: What is your UK postcode? (optional)
+ address_postcode: What's your UK postcode? (optional)
degree_status_id: Do you have a degree?
consideration_journey_stage_id: How close are you to applying for teacher training?
preferred_teaching_subject_id: What do you want to teach?
diff --git a/spec/features/event_wizard_spec.rb b/spec/features/event_wizard_spec.rb
index 39e6e3480b..976ea3186d 100644
--- a/spec/features/event_wizard_spec.rb
+++ b/spec/features/event_wizard_spec.rb
@@ -173,7 +173,7 @@
end
click_on "Complete sign up"
- expect(page).not_to have_text("What is your UK postcode? (optional)")
+ expect(page).not_to have_text("What's your UK postcode? (optional)")
fill_in_personalised_updates
expect_sign_up_with_attributes(
@@ -304,8 +304,8 @@ def fill_in_personalised_updates(
)
select_value_or_default "Do you have a degree?", degree_status
select_value_or_default "How close are you to applying for teacher training?", consideration_journey_stage
- if page.has_text?("What is your UK postcode? (optional)")
- fill_in "What is your UK postcode? (optional)", with: postcode
+ if page.has_text?("What's your UK postcode? (optional)")
+ fill_in "What's your UK postcode? (optional)", with: postcode
end
select_value_or_default "What do you want to teach?", preferred_teaching_subject
end