Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong typings on localization #954

Closed
valadas opened this issue Feb 14, 2024 · 1 comment
Closed

Wrong typings on localization #954

valadas opened this issue Feb 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@valadas
Copy link
Member

valadas commented Feb 14, 2024

v0.23.2 was refactored to have localization typings extracted into a type outside of the component. In doing so some of them were left as the exact default string instead of a string type. One of them is in dnn-image-cropper but it would be good to verify elsewhere too.
@valadas valadas added the bug Something isn't working label Feb 14, 2024
valadas added a commit to valadas/dnn-elements that referenced this issue Feb 14, 2024
@valadas
Fixed localization typings issue for image-cropper
efa3e1f 
Closes Wrong typings on localization DNNCommunity#954
@valadas valadas mentioned this issue Feb 14, 2024
Merged
@valadas
Copy link
Member Author

valadas commented Feb 14, 2024

done in #955

@valadas valadas closed this as completed Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@valadas