Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov fails to cover a random line, occasionally #152

Open
DaviDevMod opened this issue Jun 13, 2023 · 2 comments
Open

Codecov fails to cover a random line, occasionally #152

DaviDevMod opened this issue Jun 13, 2023 · 2 comments
Labels
priority: low status: deferred

Comments

@DaviDevMod
Copy link
Owner

Most recently, it happend in b2dbe54 and before that, in cc20f8d.
@DaviDevMod
Copy link
Owner Author

Possibly related to a bug in istanbuljs/nyc.

Unfortunately, the bug should not exists in these versions (comment):

    "istanbul-lib-coverage": "3.2.0",
    "istanbul-lib-instrument": "5.1.0",
    "istanbul-lib-source-maps": "4.0.1",
    "istanbul-reports": "3.0.5",

And we are in check with:

focus-trap/packages/focus-trap/package.json

Line 48 in eef9612

"istanbul-lib-coverage": "3.2.0",

Further investigation is needed.

@DaviDevMod
Copy link
Owner Author

I don't think the nyc bug is related as it is about merging two summary.json files, while this project has to deal only with one summary.

Further investigation is still needed.

@DaviDevMod DaviDevMod changed the title Occasionally, codecov fails to cover a random line Codecov fails to cover a random line, occasionally Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low status: deferred
Projects
@davidevmod/focus-trap
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DaviDevMod