Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Divide the calculation of reinforcement profile in two steps. #91

Open
4 tasks
Carsopre opened this issue Oct 18, 2023 · 0 comments
Open
4 tasks
Labels
enhancement New feature or request

Comments

@Carsopre
Copy link
Collaborator

Currently, during calculation of a reinforcement profile we also calculate the added / removed layers.

Although this is functionally working and tested, as a conseguence of issue #82 I realized we might want to split this logic into two different steps (builders). This will mean that the logic of the KoswatSummaryBuilder will have to be modified so that, after generating a ReinforcementProfile another object (which needs to be introduced in Koswat) is created containing the information of the modified geometries (added / removed values). This "new" type of ReinforcementProfile (think a name like EvaluatedReinforcementProfile) will be the one consumed later on to calculate costs.

Tasks:

  • Move the logic of a ReinforcementProfile referring to added / removed geometries into a new "subtype" EvaluatedReinforcementProfile, which should also implement the KoswatProfileProtocol.
  • Reduce the logic of both StandardReinforcementProfileBuilder and OutsideSlopeReinforcementProfileBuilder so they don't calculate the information removed in the previous point.
  • Create a new builder to calculate per ReinforcementProfile all the added / removed geometries as done previously into a new instance of a EvaluatedReinforcementProfile.
  • Adapt the KoswatSummaryBuilder so that the reinforcements are correctly created and later consumed for costs calculation.
@Carsopre Carsopre added this to the [v0.14.0] Release 2023 milestone Oct 18, 2023
@ArdtK ArdtK removed this from the [v0.14.0] Release 2023 milestone Oct 19, 2023
@Carsopre Carsopre added this to the Sprint 2024.4.2 milestone Sep 25, 2024
@Carsopre Carsopre added the enhancement New feature or request label Oct 23, 2024
@ArdtK ArdtK removed this from the Sprint 2024.4.2 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants