You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, during calculation of a reinforcement profile we also calculate the added / removed layers.
Although this is functionally working and tested, as a conseguence of issue #82 I realized we might want to split this logic into two different steps (builders). This will mean that the logic of the KoswatSummaryBuilder will have to be modified so that, after generating a ReinforcementProfile another object (which needs to be introduced in Koswat) is created containing the information of the modified geometries (added / removed values). This "new" type of ReinforcementProfile (think a name like EvaluatedReinforcementProfile) will be the one consumed later on to calculate costs.
Tasks:
Move the logic of a ReinforcementProfile referring to added / removed geometries into a new "subtype" EvaluatedReinforcementProfile, which should also implement the KoswatProfileProtocol.
Reduce the logic of both StandardReinforcementProfileBuilder and OutsideSlopeReinforcementProfileBuilder so they don't calculate the information removed in the previous point.
Create a new builder to calculate per ReinforcementProfile all the added / removed geometries as done previously into a new instance of a EvaluatedReinforcementProfile.
Adapt the KoswatSummaryBuilder so that the reinforcements are correctly created and later consumed for costs calculation.
The text was updated successfully, but these errors were encountered:
Currently, during calculation of a reinforcement profile we also calculate the added / removed layers.
Although this is functionally working and tested, as a conseguence of issue #82 I realized we might want to split this logic into two different steps (builders). This will mean that the logic of the
KoswatSummaryBuilder
will have to be modified so that, after generating aReinforcementProfile
another object (which needs to be introduced inKoswat
) is created containing the information of the modified geometries (added / removed values). This "new" type ofReinforcementProfile
(think a name likeEvaluatedReinforcementProfile
) will be the one consumed later on to calculate costs.Tasks:
ReinforcementProfile
referring to added / removed geometries into a new "subtype"EvaluatedReinforcementProfile
, which should also implement theKoswatProfileProtocol
.StandardReinforcementProfileBuilder
andOutsideSlopeReinforcementProfileBuilder
so they don't calculate the information removed in the previous point.ReinforcementProfile
all the added / removed geometries as done previously into a new instance of aEvaluatedReinforcementProfile
.KoswatSummaryBuilder
so that the reinforcements are correctly created and later consumed for costs calculation.The text was updated successfully, but these errors were encountered: