Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the way boundaries are plotted in plot_basemap #239

Open
roeldegoede opened this issue Jan 16, 2025 · 0 comments
Open

Improve the way boundaries are plotted in plot_basemap #239

roeldegoede opened this issue Jan 16, 2025 · 0 comments
Assignees
Labels
Enhancement New feature or request Needs refinement Issue still needs refinement

Comments

@roeldegoede
Copy link
Collaborator

Kind of request

Changing existing functionality

Enhancement Description

We now first vectorize the msk=2 or msk=3 cells into a line, before we plot the boundaries in the plot basemap. This doesn't work for unstructred grids (future work), and seems a bit too complex in general for very simple functionality.

  • We could convert the msk=2 cells to "dots", so no conversion to linestrings is needed
  • We could consider plotting the raster/unstructred mask, but only the boundary cells, replacing the normal active domain (msk=1) with nans.

Use case

No response

Additional Context

No response

@roeldegoede roeldegoede added Enhancement New feature or request Needs refinement Issue still needs refinement labels Jan 16, 2025
@roeldegoede roeldegoede self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs refinement Issue still needs refinement
Projects
None yet
Development

No branches or pull requests

1 participant