Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Innitial tab load doesn't show attribute fields. #63

Open
harrybigfoot opened this issue Oct 28, 2020 · 11 comments
Open

Innitial tab load doesn't show attribute fields. #63

harrybigfoot opened this issue Oct 28, 2020 · 11 comments

Comments

@harrybigfoot
Copy link

Every time i had to toggle between tabs to show the attribute fields on the first tab.
After editting line 179 i solved it with placing a show :)
179: body += '

' +
to
179: body += '
' +

Clipboard01

@harrybigfoot harrybigfoot changed the title Innitial tab load doesn't show atribute fields. Innitial tab load doesn't show attribute fields. Oct 28, 2020
@DennisSuitters
Copy link
Owner

ooopss, must be a typo.
I've in the process of updating Summernote into a completely Bootstrapless and even liter version of the Lite version, and the plugins interface may change slightly given that I'm looking at implementing things such as tooltips so they don't need to have script interaction. That said, this is why I haven't been paying much attention to plugins as of late, but will eventually get to them with rewrites.

@San4aus
Copy link

San4aus commented Dec 16, 2020

Just remove class "note-tab-content" from 105: div class="tab-content note-tab-content" in summernote-image-attributes.js. It's worked for me.

@DennisSuitters
Copy link
Owner

Ah, I forgot all about this. I am currently integrating a better solution into the Summernote Skunkworks repository for future release, and making decisions on what to include as the most important options to try and remove the need for tabs.

@ColdFusionGuy72
Copy link

Is there a proven fix for this? I can't seem to get it working.

@DennisSuitters
Copy link
Owner

I just gotta get off my butt and fix it, I again got sidetracked. I have to do some Summernote fixes in the next few days, so I'll add this to the list, as it's needed.

@ColdFusionGuy72
Copy link

Thank you! I need to roll this out for my team of developers so that fix will be super helpful. Is auto-fill of the image dimensions possible too?

@DennisSuitters
Copy link
Owner

I wasn't going to add it to this plugin, as I (should be) am working on integrating the features of this plugin into the core API of Summernote, I was looking at adding the dimensions.

@ColdFusionGuy72
Copy link

Oh man if this becomes a core item I am fine then :) I integrated it into a few of my ColdFusion apps - easily the best and easiest editor I have found out there. Thank you!

@DennisSuitters
Copy link
Owner

Not sure on what the release date is for now, dropping Bootstrap depenance as you would imagine is easy. I've been working on dropping jQuery where I can, and we'd like to also modify things so we no longer rely on the execCommand() as that is now considered deprecated.

DennisSuitters pushed a commit that referenced this issue Jul 5, 2021
Remove `note-tab-content` as a quick fix as per #63 (comment)
@DennisSuitters
Copy link
Owner

I've edited the source as per @San4aus suggestion as a quick fix for now,

@cangak
Copy link

cangak commented Feb 25, 2022

I've edited the source as per @San4aus suggestion as a quick fix for now,

i have done it too, but it still blank, now shown, any other way. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants