Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling #33

Open
2 of 5 tasks
AavHRF opened this issue Apr 2, 2023 · 1 comment · Fixed by #32 or #36
Open
2 of 5 tasks

Error Handling #33

AavHRF opened this issue Apr 2, 2023 · 1 comment · Fixed by #32 or #36
Assignees

Comments

@AavHRF
Copy link
Collaborator

AavHRF commented Apr 2, 2023

Raised partially in #32 -- the error handling for the API calls is lackluster at best, and could probably stand to be upgraded. Same for the daily dump. Ideally we should use .raise_for_status() as @esfalsa indicated in #32, and it should be used on every API call in order to catch bad data before it corrupts the program run.

Other potential options include manually parsing out the HTTP status code with an if block, which would give us the advantage of being able to fine-tune responses for various codes. This is also the moment where I note that we don't bother to do anything if the API returns a 429. That should probably be changed.

This issue should not be closed out until the following items are resolved:

@AavHRF AavHRF self-assigned this Apr 2, 2023
@AavHRF AavHRF linked a pull request Apr 2, 2023 that will close this issue
@AavHRF AavHRF closed this as completed in #32 Apr 2, 2023
@AavHRF AavHRF reopened this Apr 2, 2023
@AavHRF AavHRF linked a pull request Apr 3, 2023 that will close this issue
@AavHRF AavHRF closed this as completed in #36 Apr 4, 2023
@AavHRF
Copy link
Collaborator Author

AavHRF commented Apr 4, 2023

Gah, I forget that automation closes this. Reopening.

@AavHRF AavHRF reopened this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant