Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-Member Notifications #164

Open
ardalis opened this issue Dec 20, 2020 · 1 comment
Open

Per-Member Notifications #164

ardalis opened this issue Dec 20, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ardalis
Copy link
Collaborator

ardalis commented Dec 20, 2020

As a Member,
I would like to be notified when (various kinds of events) happen,
Via my notification medium of choice (email)


We currently have several domain events that ultimately lead to notifications being sent to Discord. Members should be able to subscribe to certain kinds of events and receive a notification direct to them via email so they don't miss things of interest to them.

Eventually this might include other means of notification such as direct Discord message or SMS but for this issue just plug in email.

@ardalis ardalis added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 20, 2020
@justSteve
Copy link
Contributor

Thinking aloud on requirements of this implementation...

It would require:

  • adding a property to the user entity to store the user-selected events.
  • presenting a list of checkboxes of all subscribable events (checked or not according to the given user's choices) -- if the user is in Admin role show AdminUpdatesWebhook and if not, show DevBetterComNotificationsWebhook
  • adding code to the base discord handler that fires non-admin events to check if the current event is on the current user's list and if so, fire an email. Does 'Infrastructure' have access to 'current user'?

If I'm reading things correctly, I think I could take on this task given a bit of handholding on how to populate the two lists. Presumably that involves 'using reflection' which, as badly as it reflects on me, is something I haven't yet mastered.

Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants