Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervised test of skipping bad samples #687

Open
DominicOram opened this issue Nov 28, 2024 · 2 comments
Open

Supervised test of skipping bad samples #687

DominicOram opened this issue Nov 28, 2024 · 2 comments
Labels

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Nov 28, 2024

Following #470 we should now be in a position where we can run a full collection in hyperion that will skip collecting on samples that do not diffract or are too long/short. We should try and prove this before the end of the run.

Things to test:

  • We can run a single collection with and w/o skipping
  • We can run a native (chi changing) collection with and w/o skipping
  • We can run a S+C with and w/o skipping
  • We can run at different energies (Soak testing energy changes #277)

Acceptance Criteria

  • The above is tested on test pins to @npat113's satisfaction
  • We run for some length of time (~.5 days) on user samples with the above whilst hyperion is being supervised
  • Any problems are spun into new issues
@DominicOram DominicOram moved this to Candidates for Next Sprint in Hyperion Nov 28, 2024
@DominicOram
Copy link
Contributor Author

For S+C removing the wait for analysis results will make this better, discuss with irakli

@DominicOram DominicOram moved this from Candidates for Next Sprint to Todo This Sprint in Hyperion Nov 28, 2024
@rtuck99
Copy link
Contributor

rtuck99 commented Dec 13, 2024

Began testing on 2024-12-05 but ran into some issues notably #703 but see also various other things from the same testing session #697

@rtuck99 rtuck99 moved this from Todo This Sprint to Blocked in Hyperion Dec 13, 2024
@rtuck99 rtuck99 moved this from Blocked to Todo This Sprint in Hyperion Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo This Sprint
Development

No branches or pull requests

2 participants