Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbird extra fields in parameter model #747

Open
olliesilvester opened this issue Jan 14, 2025 · 1 comment
Open

Forbird extra fields in parameter model #747

olliesilvester opened this issue Jan 14, 2025 · 1 comment
Assignees
@shihab-dls

Comments

@olliesilvester
Copy link
Contributor

Our top level parameter BaseModel, called MxBlueskyParameters, currently allows extra fields via

model_config = ConfigDict(
        arbitrary_types_allowed=True,
        extra="allow",
    )

This means parameter-related issues can be very hard to spot - eg things like #738. Git blames me for this so I do too! We should change this to extra=forbid" and fix tests to work with this

Acceptance Criteria

  • set extra="allow" in MxBlueskyParameters
  • Fix all tests that this breaks
  • Add a test to confirm this works as expected
@olliesilvester olliesilvester mentioned this issue Jan 14, 2025
Merged
@olliesilvester olliesilvester moved this to Todo This Sprint in Hyperion Jan 14, 2025
@olliesilvester
Copy link
Contributor Author

Wait for #746 to be merged before starting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shihab-dls shihab-dls

Labels
None yet
Projects
Hyperion
Status: Todo This Sprint
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olliesilvester @shihab-dls