Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Test Extension]: Implement "default setting unit tests" #159

Open
MalteKurz opened this issue May 19, 2022 · 0 comments
Open

[Unit Test Extension]: Implement "default setting unit tests" #159

MalteKurz opened this issue May 19, 2022 · 0 comments

Comments

@MalteKurz
Copy link
Member

In the python package DoubleML, we do have unit tests for model defaults, see https://github.com/DoubleML/doubleml-for-py/blob/master/doubleml/tests/test_doubleml_model_defaults.py. The intention behind such "default setting unit tests" is twofold:

  1. It should assert that the defaults are valid / meaningful, i.e., the code runs through successfully with default values for the input parameters.
  2. The unit tests serve as a reminder to update the documentation of defaults in case a default value is being changed.

Such "default setting unit tests" could be done for the initialization of the model classes as well as for the most important methods.

Note: Such "default setting unit tests" would have been sensitive for bugs like #155 & #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant