Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosine_bell (probably other spherical tests) use wrong refinement factors #257

Closed
xylar opened this issue Jan 2, 2025 · 2 comments · Fixed by #268
Closed

cosine_bell (probably other spherical tests) use wrong refinement factors #257

xylar opened this issue Jan 2, 2025 · 2 comments · Fixed by #268
Assignees
Labels
bug Something isn't working

Comments

@xylar
Copy link
Collaborator

xylar commented Jan 2, 2025

They should use the spherical refinement factors but they use the planar ones:

if refinement == 'time':
option = 'refinement_factors_time'
else:
option = 'refinement_factors_space'
refinement_factors = config.getlist('convergence', option, dtype=float)

@xylar xylar added the bug Something isn't working label Jan 2, 2025
@xylar xylar self-assigned this Jan 2, 2025
@xylar
Copy link
Collaborator Author

xylar commented Jan 2, 2025

I was trying to make a 960 km icos mesh and it didn't work because of this bug.

@xylar
Copy link
Collaborator Author

xylar commented Jan 25, 2025

The issue is only with the cosine bell and not with geostrophic or sphere_transport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant