Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the @context is not a context but an ontology #93

Open
VladimirAlexiev opened this issue Sep 25, 2024 · 3 comments
Open

the @context is not a context but an ontology #93

VladimirAlexiev opened this issue Sep 25, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@VladimirAlexiev
Copy link

@rivettp @jgeluk This is an important bug that makes DPROD JSONLD unusable at present.

The reason for failures like #92
is that https://ekgf.github.io/dprod/dprod.jsonld is not a context per se: it's a dump of the ontology in JSONLD.

These are different things, eg compare:

Your examples use classes like DataProduct, DataProductAgreement. But these terms are not defined in the context, so no triples come out.

I strongly recommend to use prefixed terms like dprod:DataProduct, dprod:DataProductAgreement and NOT bare terms like DataProduct, DataProductAgreement

  • We did that in EPCIS, and as a result it's harder to use EPCIS together with other JSONLD contexts.
  • The EPCIS context is over-optimized, but that was necessary since EPCIS JSON doesn't have prefixes.
  • EPCIS+CBV are used pretty much alone (not mixed with other data), but I think DPROD will be mixed with other data on a regular basis
@steve165
Copy link
Contributor

DataProductAgreement is not part of DPROD so doesn't have a dprod prefix. It is an example created to illustrate how to use other definitions (in this case subclassing a FIBO Agreement, but should not be considered as the only option). To be explicit I assume we would just use ex:DataProductAgreement?

@VladimirAlexiev
Copy link
Author

@steve165 yuo're right, "agreement" only appears in core-data-product-extensions/example2.jsonld:

      "@type": "ex:DataProductagreement"

@steve165
Copy link
Contributor

steve165 commented Sep 27, 2024

There is a typo tho (sigh). (My typo, I should add)

@rivettp rivettp added the bug Something isn't working label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants