-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site-wide Link Design Update (Aug-2020) #27
Comments
Do we plan to add individual pages for all the news articles? If not, I will take away the links... so that it looks less misleading. However, the normal font for the news heading makes it seem trivial so... I think we should make them bold. Haha I understand the article you sent now. It's confusing to know what is a link when the EPICLab site has inconsistent link formatting. I think having links in blue would be the most obvious to users, but it makes the site seem too conventional. They would also make the Publications Page very hard to read due to the abundance of links. I looked at the STRUDEL Lab's website, and they made their links in red. When a user hovers over a link, the red color becomes slightly more saturated. I like how that design goes along with their website aesthetics and how it doesn't involve bold text, which can then be used for key points and big ideas. Amy X. Zhang's website has the links in bold. For her website design, it works well, and when a user hovers over the links, they turn a bright yellow, indicating an obvious link. However, since the publication titles are in bold, I thought they'd have links too, which they didn't. So bold links might be misleading. For our People Page, the links are quite confusing since all the people have their names in bold, but only certain names have links. However, if we were to make the names with links in different colors, I think that would be even worse since the design would be very inconsistent. Underlined links are nice, but they might be too messy. Should we just do a mix of all of them? |
I would like to have a single design for all links (which are defined by a:link {
color: #547599;
text-decoration: none;
cursor: auto;
}
a:hover {
color: #547599;
text-decoration: underline;
}
a:visited {
color: inherit;
text-decoration: underline;
} As reference, the CSS Default Values Reference. Although that W3School site doesn't include actual values for those CSS defaults, it does indicate which fields are set. And at least in Firefox, the default link color is #0056b3 (I updated my example above to a color that is closer to the color palette of the rest of the EPICLab website). |
I've removed the link icon that pops up for publications/people and created the CSS code, but for some reason, the links don't change color. They remain black. Also, later on, should we label the publications that have won awards? |
It would be easier to diagnose the indicated problem if you commit your changes to the
The property that is directly setting the link text to be black is .site-link {
font-size: 1rem;
font-weight: bold;
line-height: 1.5;
color: black;
} I think adding something to signify awards would be appropriate, but not as part of this issue. If you want to suggest it in a new issue, we can discuss how to design such a feature. |
I've committed my changes and tried to do all the changes you sent, but the links still remain black. Do I need to make a separate class for them? |
I looked into the code and figured out the problem. The following CSS rule in a:visited {
color: inherit;
...
} I pushed d22c4c6 to resolve the issue. |
Since both I think we can go ahead and use this current color palette for now. Perhaps later on we can do an accessibility evaluation to determine whether this coloring is appropriate for color-blindness and/or screen-readers, but for now it appears to work. |
Sounds good! I won't send out a pull request yet because it would include the research pages, which aren't ready yet. For Usable Privacy & Security, I couldn't find any publications, so should I just leave the list blank? |
There are publications for the Usable Privacy & Security research area, and one of them is actually a VL/HCC 2017 short paper:
I'll have to ask Mahsa for any additional papers in that area. She will also be the point person for providing a description of that research area. |
I'm not recommending it, since it's not a simple process. But there is a way of creating a new branch (based off of your |
|
Like I said, there is a bit more of a learning curve than we really need to tackle right now. So go with the combined PR. |
The default web design standard for links is that they be shown as blue text, which becomes a darker blue and underlined on hover (to suggest that mouse actions such as clicking are possible on that text). The Nielsen Norman Group (of Nielsen's 10 Usability Heuristics fame) has a good article, "Guidelines for Visualizing Links", that discusses design best practices for links.
There are currently several different link visualization designs being used throughout the
EPICLab.github.io
site, including:Button links that change text color when the mouse is hovered.
External links that adhere to the default blue text that changes color and underlined on hover.
We need to develop a unified standard for how we visually communicate links throughout the website. This issue is an expansion of some discussion found in #26.
The text was updated successfully, but these errors were encountered: