Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build is presently broken on account of ratatui-binary-data-widget dependency #173

Closed
froztbyte opened this issue Jul 15, 2024 · 2 comments

Comments

@froztbyte
Copy link

heya

currently this fails to build because ratatui-binary-data-widget upstream has changed:

error[E0308]: mismatched types
  --> src/interactive/details/payload_view.rs:88:62
   |
88 |         let max_lines = widget.get_max_lines_of_data_in_area(area);
   |                                ----------------------------- ^^^^ expected `ratatui::layout::rect::Rect`, found `Rect`
   |                                |
   |                                arguments to this method are incorrect

setting it to build off 834ab06c030f4069e83b25d39582508fb0faceae succeeds

@EdJoPaTo
Copy link
Owner

Yeah. The binary widget is already at ratataui 0.27 but mqttui itself is still at 0.26 as it creates bugs to update (#172).

The build should work when using the lockfile. Cargo run and build do so by default. cargo install --locked should apply this to install.

When the lockfile is not updated it should be no problem? (At least that's the point of the lockfile.) Or am I overlooking something?

@EdJoPaTo
Copy link
Owner

I reverted that change in ratatui-binary-data-widget. Will update both that and mqttui at the same time once ratatui/ratatui#1226 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants