Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion -- Adding hex codes, issues with line spacing #3

Open
doak-m opened this issue Dec 1, 2022 · 1 comment
Open

Suggestion -- Adding hex codes, issues with line spacing #3

doak-m opened this issue Dec 1, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@doak-m
Copy link

doak-m commented Dec 1, 2022

Since books can now support hex colour formats, I believe it's possible to implement this into the program to produce colours more accurate to the image given.

I've also encountered a problem where my images on the book would be stretched vertically, I believe this is due to how line spacing on the Minecraft books creates more vertical space.

Perhaps there could be an optional switch to compensate for this stretch?
Deforming the source image in the program could fix the issue, however this would decrease the image quality especially for stuff like pixel art where the image is to-scale to begin with,
or parts of the image can be 'erased' according to where the line spaces occur, which would conserve quality at the loss of parts of the image being erased.

Hopefully you're still working on this project, I've found this really useful as the only tool capable of bringing images to Minecraft books!

@Equbuxu Equbuxu added the enhancement New feature or request label Jan 18, 2023
@Equbuxu
Copy link
Owner

Equbuxu commented Jan 18, 2023

I haven't touched this project in a loong time, but maybe I will update in the future if I find some free time and motivation. I haven't heard that they added hex color support, but it sounds great. As for the stretch, you are right about the code not accounting for gaps between lines in any way. The two options you mentioned (stretching the image and skipping lines) are probably the only viable ways to go about it. You can already do both by pre-processing the image yourself You'd do that by either by "squishing" (resizing) the image vertically before you pass it to the app, or by keeping the first 4 rows of pixels, then deleting 2-3 rows, then keeping another 4, then deleting, ... , and finally moving all of he kept strips together to produce a "squished" image). It's definitely very annoying to do though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants