Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox selectedItems prop sometimes stale in calciteComboboxChange handler #11382

Open
2 of 6 tasks
nwhittaker opened this issue Jan 25, 2025 · 0 comments
Open
2 of 6 tasks
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. impact - p0 - emergency User set priority impact status of p0 - emergency needs triage Planning workflow - pending design/dev review.

Comments

@nwhittaker
Copy link
Contributor

Check existing issues

Actual Behavior

Given a <calcite-combobox> with allow-custom-values enabled, typing in a custom value triggers the calciteComboboxChange event. However, in the event's handler, the target combobox's selectedItems prop does not include the selected item.

Screen.Recording.2025-01-24.at.6.56.36.PM.mov

Expected Behavior

The target combobox's selectedItems prop does include the selected item by the time the calciteComboboxChange emits.

Screen.Recording.2025-01-24.at.6.57.57.PM.mov

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/vEBQeyG

Reproduction Steps

  1. Visit the repro and open the dev tools console.
  2. Click the combobox and type in a custom value.
  3. Observe the logged combobox.selectedItems value does not include the item selected in step 2.

Reproduction Version

3.0.0-next.111

Relevant Info

Possibly related to #11381.

Regression?

2.13.2

Priority impact

impact - p0 - emergency

Impact

A workaround is to derive the selectedItems prop from the combobox's child elements. However it'd be a high level of effort to fix for every combobox instance in our code base. Requesting p0 priority as Field Maps is looking to release with Calcite 3 in a few weeks.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps

@nwhittaker nwhittaker added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jan 25, 2025
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. impact - p0 - emergency User set priority impact status of p0 - emergency labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. impact - p0 - emergency User set priority impact status of p0 - emergency needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

1 participant