Empty reports left for approval when all expenses are rejected to and Instant Submit is enabled

[garrettmknight]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: All
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation (hyperlinked to channel name): expense

Action Performed:

1. Create a workspace
2. Enable approvals
3. Invite a submitter
4. As the submitter, create an expense
5. As the approver, reject the individual expense in Classic

Expected Result:

When the last transaction is removed from a report, the report should be automatically deleted so long as there aren't any user comments on it. If there are user comments, the report should be changed to a chat report. This ensures that we maintain any relevant context and that approvers are not left with empty reports requiring approval.

Actual Result:

The report remains in the approval queue, empty and requiring action from the approver.

Workaround:

N/A

Platforms:

All

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[garrettmknight]

Note that this is similar to #54787; however, the trigger is the approver rejecting instead of an expense merging on SmartScan so it likely needs to be handled in a different command.

[JmillsExpensify]

Internal, so we're still waiting on this Expensify volunteers to pick this up as part of the overall project.

[melvin-bot]

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[garrettmknight]

@waterim If you're thinking of working on #54787 this could be a good one to tackle too.

[waterim]

Hello, sure, Im Artem from Callstack and would like to help with this issue!

[melvin-bot]

@JmillsExpensify, @waterim Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

Assigned

[melvin-bot]

@JmillsExpensify @waterim this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[waterim]

Hello, Im working on this issue, was not able to fix this issue yet, but will have more time next week to finish!