Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable list item #5

Open
oliverjam opened this issue May 31, 2019 · 0 comments
Open

Clickable list item #5

oliverjam opened this issue May 31, 2019 · 0 comments

Comments

@oliverjam
Copy link

<li className="digits" onClick={() => handleLetterSelection(letter)}>

Generally if you're attaching an onClick to something it should be a button. That way assistive technology recognises it as interactive. Also you get some extra behaviours for free—keyboard focus and handling (enter/spacebar will fire a button too).

You can put a button inside an li

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant