Incorrect number of placement games

[BlackYps]

Some people have to play 10 placement games instead of 3 even though they were ranked in the season before. This is apparently consistent behaviour for some people while others are not affected by this bug at all.

[BlackYps]

My first guess is that the database fetch here doesn't find the player for some reason. A player that is affected by this is Dorset. https://forum.faforever.com/topic/8624/ladder-rant-because-i-am-noob/5

[BlackYps]

Further investigation showed that the database fetch works as intended, but the function itself is wrong. It should check if the player was ranked in any of the previous seasons. I.e. if the subdivision_id is not null in any of the returned rows.
But instead the function only grabs the first row and checks there. Normally this first row will be the first season where the player has ever played a game. This explains why it happens consistently for some players and not for others. It depends on if you were ranked in the first season where you played.