Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Verify successful build of Nipype graphs for each config #3

Closed
1 task
shnizzedy opened this issue May 19, 2022 · 3 comments
Closed
1 task

✅ Verify successful build of Nipype graphs for each config #3

shnizzedy opened this issue May 19, 2022 · 3 comments

Comments

@shnizzedy
Copy link
Member

shnizzedy commented May 19, 2022

Related problem

We currently only run these smoke tests by explicitly running them when the CI could run them all for us every time!

Proposed feature

For each packaged preconfig, run test_config for each test subject.

Knock out FCP-INDI/C-PAC#1680 first to keep the list of packaged preconfigs always current

Acceptance criteria

  • CI runs test_config for each test subject on PR

Alternatives

No response

Additional context

These run, but there's so many it takes a long time (see #7: Proposed Feature), so I think we should:

1. Just run a small handful (1 ‒ 3) of smoke tests on open PRs to `develop`

2. Run the full suite of smoke tests on pushes / successful merges to `develop`

3. Run the full suite of smoke tests on open PRs to `main`

@shnizzedy, #3 (comment)

@shnizzedy
Copy link
Member Author

These run, but there's so many it takes a long time (see #7: Proposed Feature), so I think we should:

  1. Just run a small handful (1 ‒ 3) of smoke tests on open PRs to develop
  2. Run the full suite of smoke tests on pushes / successful merges to develop
  3. Run the full suite of smoke tests on open PRs to main

@shnizzedy
Copy link
Member Author

1 sub per dataset, only on main image

CNL Weekly Meetings 06/09/2022: smoke tests

@shnizzedy
Copy link
Member Author

Deprecated by #1842

Repository owner moved this from In Progress to Done in Automate testing Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant