Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exceptions that matter should be reported (fail-early) #48

Open
22 of 42 tasks
FenPhoenix opened this issue Nov 2, 2019 · 0 comments
Open
22 of 42 tasks

Exceptions that matter should be reported (fail-early) #48

FenPhoenix opened this issue Nov 2, 2019 · 0 comments
Assignees
@FenPhoenix
Labels
enhancement New feature or request

Comments

@FenPhoenix
Copy link
Owner

FenPhoenix commented Nov 2, 2019 •
edited
Loading

We have far too many places where we just swallow and log exceptions and then move on like nothing happened. We should stop kidding ourselves and inform the user of important errors.

  • Core
    • Init()
    • OpenSettings()
    • SetGameDataFromDisk()
    • RefreshFMsListFromDisk()
    • AddDML()
    • RemoveDML()
    • GetDMLFiles()
    • OpenFMFolder()
    • OpenWebSearchUrl()
    • ViewHTMLReadme()
    • OpenHelpFile()
    • OpenLink()
    • EnvironmentExitDoShutdownTasks()
    • DoShutdownTasks()
    • Shutdown()
  • FindFMs
  • Scanner
  • Game config files
  • FMData.ini
  • Config.ini
  • Install/uninstall/play
    • Pre-checks before install and uninstall
    • Failed installs (error dialog and cleanup)
      • Failed cleanup of failed or canceled install
    • Failed generation of missing missflag.str
    • Failed to write stub comm file
    • Failed to start exe
    • Check for used .mis files
    • Check if OldDark
    • Check if palette fix required
  • Backup/restore
    • Backup
    • Restore
  • Cache
  • Import
  • Audio conversion
  • FMLanguages
  • FFmpeg.NET.Engine
  • Settings window
  • Mods list read fail
  • FM languages read fail

[add others here]
@FenPhoenix FenPhoenix added the enhancement New feature or request label Nov 2, 2019
@FenPhoenix FenPhoenix added this to the vNext milestone Nov 2, 2019
@FenPhoenix FenPhoenix self-assigned this Nov 2, 2019
@FenPhoenix FenPhoenix changed the title Fail fast Exceptions that matter should be reported (fail-early) Nov 5, 2019
@FenPhoenix FenPhoenix removed this from the 1.2-next milestone Nov 6, 2019
@FenPhoenix FenPhoenix pinned this issue May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FenPhoenix FenPhoenix

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FenPhoenix