Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a scheduled change's go-live date still causes tasks to execute at the original date #5030

Open
3 of 4 tasks
rolodato opened this issue Jan 21, 2025 · 0 comments
Open
3 of 4 tasks
Labels
bug Something isn't working

Comments

@rolodato
Copy link
Member

rolodato commented Jan 21, 2025

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

Editing a scheduled change to happen in the future will still cause scheduled tasks such as webhooks, Slack notifications and audit logs to execute at the original date. This can cause false alarms and incorrect audit log records, which decreases trust in the platform.

Steps To Reproduce

  1. In an environment with versioning and change requests disabled, schedule any flag update for ~2 mins in the future
  2. Edit the created scheduled change to be later, e.g. in 1 hour
  3. After 2 minutes, an audit log entry is created for the supposed scheduled change that went live. Integrations such as webhooks and Slack notifications will also fire, but the flag was never changed.

Expected behavior

Run scheduled tasks at the expected times.

Screenshots

These audit logs are from these events:

  • The scheduled change was created, originally as Enable my_feat in 2 min
  • Renamed the scheduled change to Enable my_feat in 1 hour and edited the deadline - no audit log entry is shown
  • The scheduled tasks for the original go-live date ran, but the flag was not updated.

Image

There are also some UI/timezone issues here:

  • The times are displayed in 24-hour format but with am/pm, e.g. 18:28pm. This is redundant and not used anywhere to my knowledge.
  • The latest audit log entry's time is incorrect. It is currently 17:38, so this is showing a time in the future (18:28pm)
  • The "Flag state / Remote Config" entry's date is shown in the server's timezone (running in Kubernetes, so likely UTC) but the Date column is shown in my local timezone (UTC-3).
@rolodato rolodato added the bug Something isn't working label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant