Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Gracefully keep translated texts in the transaction where API limits exceeded #94

Open
ConfusedVorlon opened this issue Apr 3, 2023 · 4 comments
Assignees
Labels
Feature Request New functionality the app doesn't provide yet Size: Tiny Probably less than 1 day of work

Comments

@ConfusedVorlon
Copy link

Steps to Reproduce:

translating a large batch of strings using Microsoft Translator
request limit exceeded

Expected Behavior:

the succesfull translations should be inserted in my Strings

Current Behavior:

error shown, Remafox gives up

Environment

@ConfusedVorlon
Copy link
Author

The batch was about 308 translations for 5 languages

@Jeehut
Copy link
Member

Jeehut commented Apr 4, 2023

@ConfusedVorlon Thank you for reporting this.

To make me fully understand the issue here, can you please explain how you did the "batch translation"? Did you use the build script? Did you start it from the Config file? If the latter, did you use "empty only" or "override all"?

Also, what you're trying to say is that if of those 308 translation keys, say 100 could be translated and the others failed, RemafoX should at least insert the 100 and can still error with "not all translations could be translated" after that, right?

@Jeehut Jeehut added the Needs More Information A bug/feature which is unclear label Apr 4, 2023
@ConfusedVorlon
Copy link
Author

I clicked "translate empty strings" in the app

yes, if 100 were translated. Then save those.
That way there are fewer next attempt, and it won't hit the request limit for ever

@Jeehut
Copy link
Member

Jeehut commented Apr 4, 2023

Thank you for the clarification. Of course, it makes sense to keep what has been successfully translated!

@Jeehut Jeehut added Feature Request New functionality the app doesn't provide yet Size: Tiny Probably less than 1 day of work and removed Needs More Information A bug/feature which is unclear labels Apr 15, 2023
@Jeehut Jeehut changed the title [Bug] If you exceed request limits - all succesful translations are lost [Feat] If you exceed request limits - all succesful translations are lost Apr 15, 2023
@Jeehut Jeehut changed the title [Feat] If you exceed request limits - all succesful translations are lost [Feat] Gracefully keep translated texts in a half-way transaction when API limits exceeded Apr 15, 2023
@Jeehut Jeehut changed the title [Feat] Gracefully keep translated texts in a half-way transaction when API limits exceeded [Feat] Gracefully keep translated texts in the transaction where API limits exceeded Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New functionality the app doesn't provide yet Size: Tiny Probably less than 1 day of work
Projects
None yet
Development

No branches or pull requests

2 participants