Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align demos with the structure of AddonStarter #128

Open
javier-godoy opened this issue Oct 28, 2024 · 2 comments
Open

Align demos with the structure of AddonStarter #128

javier-godoy opened this issue Oct 28, 2024 · 2 comments
Assignees
@javier-godoy

Comments

@javier-godoy
Copy link
Member

javier-godoy commented Oct 28, 2024 •
edited
Loading

Describe the bug

#125 did not pass the tests in AddonsDemo

Expected behavior

LayoutTest must pass

Minimal reproducible example

https://github.com/FlowingCode/AppLayoutAddon

Add-on Version

6.0.1-SNAPSHOT

Vaadin Version

24.5.0

Additional information

See https://github.com/FlowingCode/AddonsDemo/blob/vaadin24/src/test/java/com/flowingcode/vaadin/addons/LayoutTest.java
@github-project-automation github-project-automation bot moved this to Inbox (needs triage) in Flowing Code Addons Oct 28, 2024
@javier-godoy
Copy link
Member Author

javier-godoy commented Oct 29, 2024 •
edited
Loading

I did reset the master branch and moved the code of #125 to new-demo

@javier-godoy javier-godoy moved this from Inbox (needs triage) to In Progress in Flowing Code Addons Oct 29, 2024
@mlopezFC
Copy link
Member

@javier-godoy is this still a thing?

@mlopezFC mlopezFC assigned javier-godoy and unassigned mlopezFC Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javier-godoy javier-godoy

Labels
None yet
Projects
Flowing Code Addons
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@javier-godoy @mlopezFC