You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem is thus: A huge advantage of using vcr is that tests run quickly -> you can then iterate quickly b/c you don't have to lose train of thought while you make change, run tests, make change, repeat.
However, right now we use tenacity to do HTTP retries for some methods in the CromwellApi class when we do REAL HTTP requests because if we do a request too early we may get a 404, but if we do a back off and wait a bit and try again we may get a 200 response, great.
Options:
Somehow do not record http retries in vcr cassettes. I couldn't quickly find a solution for this, but there may be one. There's no utility in saving the retries. without the retries saved in cassettes, tenacity wouldn't trigger a wait cycle -> faster tests. Played with this a bit but couldn't sort it out just yet
The problem is thus: A huge advantage of using vcr is that tests run quickly -> you can then iterate quickly b/c you don't have to lose train of thought while you make change, run tests, make change, repeat.
However, right now we use
tenacity
to do HTTP retries for some methods in theCromwellApi
class when we do REAL HTTP requests because if we do a request too early we may get a 404, but if we do a back off and wait a bit and try again we may get a 200 response, great.Options:
tenacity
wouldn't trigger a wait cycle -> faster tests. Played with this a bit but couldn't sort it out just yetsys.sleep
's) coming fromtenacity
when we're not making real HTTP requests - so tests run more quickly Disablewait
for unittest jd/tenacity#106 https://stackoverflow.com/questions/47906671/python-retry-with-tenacity-disable-wait-for-unittestrelated #52
The text was updated successfully, but these errors were encountered: