Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects with duplicate source code repository URLs #1

Open
Frumple opened this issue Jan 3, 2025 · 0 comments
Open

Projects with duplicate source code repository URLs #1

Frumple opened this issue Jan 3, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Frumple
Copy link
Owner

Frumple commented Jan 3, 2025

Problem

There are a number of projects that, for various or unknown reasons, have the same source code repository URL as other projects on the same plugin repository. When this happens, MC Plugin Finder creates duplicate entries if one of the plugins is also on another plugin repository.

Examples

More examples may be added as they are discovered.

NobleWhitelist and NobleWhitelistDiscord

Reproduction Step: Search "noble" on MC Plugin Finder.

image

This plugin's author has both plugins share the same GitHub repo, but each plugin has its own separate project on Spigot, Modrinth, and Hangar, for a total of 6 projects. However, with the way MC Plugin Finder merges these projects, it attempts to consider every combination as its own entry, and thus ends up with 8 entries when there should only be 2.

InvGames and PlaceholderAPI

Reproduction Step: Search "invgames" on MC Plugin Finder.

image

For some reason, the InvGames plugin on Spigot has the same source code URL as the popular PlaceholderAPI plugin. It is unknown whether this was intentionally put in by the plugin author or caused by some other upstream error from Spigot.

tuto Skript numéros and Chunky

Reproduction Step: Search "chunky" on MC Plugin Finder.

image

Similar to InvGames, the tuto Skript numéros plugin on Spigot is reported by the Spiget API to have the same source code URL as the popular Chunky plugin. However in this case, the Spigot page doesn't show any source code URL stored. It is unknown whether this error is originating from the Spiget API, or further upstream from Spigot.

Possible Solutions

More solutions may be added later.

Currently there is no known solution for the "NobleWhitelist" issue.

Curated list of "bad" projects

To solve the issue of projects having incorrect source code URLs, we could store a curated list or database table of such projects. The ingest tool can then ignore or correct the source code URL when the project is encountered. A more extreme approach would have a list of "excluded" projects and just not add the project if it's in the list.

The downside of this is the list would have to manually maintained, though this might be acceptable if the number of projects that behave this way is small.

@Frumple Frumple added the bug Something isn't working label Jan 3, 2025
@Frumple Frumple self-assigned this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant