Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figma: update specs/diff #7

Open
reez opened this issue Feb 5, 2022 · 6 comments
Open

figma: update specs/diff #7

reez opened this issue Feb 5, 2022 · 6 comments

Comments

@reez
Copy link

reez commented Feb 5, 2022

Hi!

I was wondering if there was a diff or anything of the changes from the Figma:

  • "Overall revisions of screens, focusing on mobile, and adding Lightning features." October 15, 2021
  • "Clean-up & tweaks for more awesomeness." February 3, 2022

Its super helpful that you wrote comments for the changes like above to know what things in general have changed, so thank you for doing that extra, it is really nice that you've been doing that!

But I didn't know if there was an additional way to know in detail what items in what ways were added/revised/tweaked so I can make sure WalletUI stays matched with Bitcoin Wallet UI Kit. Any direction you can point me in or guidance as I make those updates to make sure I don't miss anything?

reez/BitcoinUI#53
reez/BitcoinUI#54

@GBKS
Copy link
Owner

GBKS commented Feb 7, 2022

I'd love to have that, but our design tools are not there yet unfortunately. Figma has a branching feature which should allow for better documentation of versions, but it requires an enterprise account. I do hope they make it available to us plebs some day soon.

For now, the best thing we can do is stay in touch and collaborate. Overall, I have not made any noteworthy changes to the colors, components, icons, etc. It was really about ensuring those are properly applied everywhere and iterating the screen mock-ups. Since all of this is in my head, I should take a big of time and review what you have and list out anything that has changed. How does that sound?

@reez
Copy link
Author

reez commented Feb 7, 2022

Ah I didn't realize branching was enterprise only, bummer!

Well I don't want you to have to do a big review since you already do so much to help, so maybe I can sit down and try to deep dive to hammer out everything I can find, then I can add you to review my PR just to see if you can spot anything I didn't catch? I'm hoping to minimize the time you have to expend (but also want to make sure I catch all the changes so the iOS SDK can have all the good new stuff you've created).

So I think that's what I'll do if you're good with me adding you as a reviewer on the PR(s), and you can review them at whatever pace works for you?

Thanks @GBKS !

@GBKS
Copy link
Owner

GBKS commented Nov 23, 2023

Is it worth picking up this discussion again?

@reez
Copy link
Author

reez commented Nov 25, 2023

sure, do you feel like you've come across a new/good option for this (did Figma allow branching for non-enterprise, etc)

@GBKS
Copy link
Owner

GBKS commented Nov 27, 2023

Unfortunately not and the way things are going, Figma does not seem interested in accommodating open-source. But we don't have to have everything be super accurate and perfect. A lot of times, you can capture the majority of differences with some clicking around and taking and annotating screenshots.

@reez
Copy link
Author

reez commented Nov 27, 2023

Got it, and yeah that makes sense, would definitely love something like that if it works for ya!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants