Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back button UX during active QF rounds #4928

Open
3 tasks
laurenluz opened this issue Jan 7, 2025 · 6 comments
Open
3 tasks

Fix back button UX during active QF rounds #4928

laurenluz opened this issue Jan 7, 2025 · 6 comments
Assignees
Labels
QF Quadratic Funding Related

Comments

@laurenluz
Copy link
Member

laurenluz commented Jan 7, 2025

After donating to a project in an active QF round, from the donation page or from the project single page, clicking the "back" button should direct the user to giveth.io/qf and not the general projects page.

Image

AC

  • When users make successful donation to project inside of current active qf round pushing the back button takes them to qf/all page
  • When users make successful donation to project NOT INCLUDED of current active qf round pushing the back button takes them to ALL PROJECTS page
  • When users make successful donation to project and THERE IS NO active qf round pushing the back button takes them to ALL PROJECTS page
@laurenluz laurenluz added the QF Quadratic Funding Related label Jan 7, 2025
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jan 7, 2025
@laurenluz laurenluz moved this from New Issues to Product Backlog in All-Devs Jan 7, 2025
@laurenluz laurenluz moved this from New Issues to Product Backlog in QF: Quadratic funding Jan 7, 2025
@divine-comedian
Copy link
Contributor

@laurenluz

I added an image and clarified some Acceptance Criteria to your issue - please clarify these are correct.

@laurenluz
Copy link
Member Author

laurenluz commented Jan 13, 2025

looks great - thanks @divine-comedian - would LOVE to have this on prod before the QF round starts on Jan 28 🙏

@laurenluz laurenluz moved this from Product Backlog to Sprint Backlog in All-Devs Jan 21, 2025
@kkatusic
Copy link
Collaborator

@divine-comedian we don't have back button on project single/detailed page

@kkatusic kkatusic moved this from Sprint Backlog to Code Review/PR in All-Devs Jan 22, 2025
@kkatusic kkatusic moved this from Product Backlog to Code Review/PR in QF: Quadratic funding Jan 22, 2025
@divine-comedian
Copy link
Contributor

divine-comedian commented Jan 22, 2025

@divine-comedian we don't have back button on project single/detailed page

you are 100% right! In that case we will only need to handle donation success page. AC has been updated.

@kkatusic kkatusic moved this from Code Review/PR to QA in All-Devs Jan 23, 2025
@kkatusic kkatusic moved this from Code Review/PR to QA in QF: Quadratic funding Jan 23, 2025
@divine-comedian
Copy link
Contributor

@LatifatAbdullahi ready for QA

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Jan 23, 2025

Test Update

Thanks @kkatusic

  • When users make successful donation to project inside of current active qf round pushing the back button takes them to qf/all page - Pass

  • When users make successful donation to project NOT INCLUDED of current active qf round pushing the back button takes them to ALL PROJECTS page - Pass

  • When users make successful donation to project and THERE IS NO active qf round pushing the back button takes them to ALL PROJECTS page - Pass

  1. When users make successful donation to project inside of current active qf round pushing the back button takes them to qf/all page
    https://github.com/user-attachments/assets/9e15bf15-cf2f-4551-ae3c-0d16bf641ce5

  2. When users make successful donation to project NOT INCLUDED of current active qf round pushing the back button takes them to ALL PROJECTS page

testimehr._.Giveth.-.Google.Chrome.2025-01-23.16-33-35.mp4
  1. When users make successful donation to project and THERE IS NO active qf round pushing the back button takes them to ALL PROJECTS page

Donating to a project that was part of the current QF around after deactivating the QF round.

A.delicious.help._.Giveth.-.Google.Chrome.2025-01-23.16-56-34.mp4

@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in QF: Quadratic funding Jan 23, 2025
@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in All-Devs Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QF Quadratic Funding Related
Projects
Status: Done
Status: Done
Development

No branches or pull requests

5 participants