Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update banner for Loving on Public Goods Round - by @jan 16 #4937

Closed
yegorgolovnia opened this issue Jan 15, 2025 · 6 comments
Closed

Update banner for Loving on Public Goods Round - by @jan 16 #4937

yegorgolovnia opened this issue Jan 15, 2025 · 6 comments
Assignees

Comments

@yegorgolovnia
Copy link
Collaborator

Dapp Background
https://www.figma.com/design/W9Ace1RyCdykWM72fsSa3t/Giveth-Marketing-2024

We should add the banner without any sponsors. (we don't have any sponsors yet, so we need to get it in prod asap, and then we will need to updaet the banner again once we have sponsors confirmed)
When I tried to upload the banner via admin bro-- it showed the last hardcoded banner, so I set the round to inactive

@divine-comedian
Copy link
Contributor

divine-comedian commented Jan 15, 2025

got a double-sized image from figma and uploaded it as a PNG file into the admin panel and seems to work!

image

@divine-comedian
Copy link
Contributor

divine-comedian commented Jan 15, 2025

If you're satisfied @yegorgolovnia let me know or simply close this issue.

@divine-comedian
Copy link
Contributor

It appears that the app is not handling SVG files well, other archived banners appear to be broken when you try to load them.

In the issue stated above we needed to upload a PNG file instead of SVG however the resolution does not look good on the app itself

for example:
https://giveth.io/qf-archive/GIV-a-Palooza

image

The fact that this archived banner now shows as broken means at one point SVG files worked fine and now they don't...

@yegorgolovnia
Copy link
Collaborator Author

If you're satisfied @yegorgolovnia let me know or simply close this issue.

@divine-comedian to clarify – at the end you ended up reuploading the banner via adminbro? I got a banner in 1921 × 640, but don't want to mess reuploading via adminbro, before I hear this is how you did it at the end

the banner still looks quite pixelated, unless this is how they always look :)

I scrolled throughout a few prev rounds and some banners do look pixelated, but for example on the main page of QF, it looks really good
image

@divine-comedian
Copy link
Contributor

@yegorgolovnia something is definitely wrong, either they look pixelated (PNG file) or the uploaded banner is broken - look at the GIV a palooza archived banner.

I made a follow-up issue in #4938 assuming it is not mission critical - the banner is up, just looks pixelated.

Likely this default banner is hardcoded svg so there isn't any issues with uploaded and rendering the file from the back-end/admin panel.

@yegorgolovnia
Copy link
Collaborator Author

Thanks @divine-comedian

re GIV a palooza: it actually never loaded the banner for me, only a placeholder

image

but yeah, the banner is up, so thats good already

thank you! <3

@github-project-automation github-project-automation bot moved this from New Issues to Done in All-Devs Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants